From 80a2ba78a2c91a9f4a13bfa9ed85e943ffd8d8c2 Mon Sep 17 00:00:00 2001 From: Reimar Date: Mon, 27 Oct 2025 12:45:07 +0100 Subject: [PATCH] Various code improvements --- src/Map.cpp | 2 +- src/Map.hpp | 2 +- src/Player.hpp | 2 +- src/main.cpp | 3 +-- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/Map.cpp b/src/Map.cpp index c472f1e..0ab4085 100644 --- a/src/Map.cpp +++ b/src/Map.cpp @@ -28,7 +28,7 @@ Map::Map(GameRenderer *renderer, int tile_size) : } } -std::vector Map::generate_tiles(std::vector prev_tiles) const +std::vector Map::generate_tiles(const std::vector &prev_tiles) const { std::vector new_tiles = std::vector(prev_tiles.size(), Tile::grass); diff --git a/src/Map.hpp b/src/Map.hpp index efe0f6c..5712c5a 100644 --- a/src/Map.hpp +++ b/src/Map.hpp @@ -18,7 +18,7 @@ private: Sprite grass_sprite; Sprite path_sprite; - std::vector generate_tiles(std::vector prev_tiles) const; + [[nodiscard]] std::vector generate_tiles(const std::vector &prev_tiles) const; public: Map(GameRenderer *renderer, int tile_size); diff --git a/src/Player.hpp b/src/Player.hpp index 6932f1e..c1c0728 100644 --- a/src/Player.hpp +++ b/src/Player.hpp @@ -18,7 +18,7 @@ public: double angle = 0.0; - const double speed = 1.5; + static constexpr double speed = 1.5; Player(GameRenderer *renderer); diff --git a/src/main.cpp b/src/main.cpp index a3059ad..f394338 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -5,8 +5,7 @@ int main() { srand(time(nullptr)); - Game game = Game(); - + Game game; game.run(); return 0;